[ 
https://issues.apache.org/jira/browse/CALCITE-5615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713701#comment-17713701
 ] 

Mihai Budiu commented on CALCITE-5615:
--------------------------------------

These are all the dependencies of this project:

    implementation(project(":core"))
    implementation("org.hsqldb:hsqldb")
    compileOnly("com.google.code.findbugs:jsr305:3.0.2")
    testCompileOnly("com.google.code.findbugs:jsr305:3.0.2")
    implementation("com.beust:jcommander:1.71")

I can remove findbugs and jcommander, leaving only core and hsqldb. Is this 
what you are suggesting?

Writing unit tests will be a bit more difficult, because the output of the 
program is a list of bugs in calcite, and as these bugs are fixed, the output 
should change... Perhaps if all tests use the -n flag which is supposed to do 
nothing?

The program as it exists currently is designed for human consumption; it 
outputs bug reports on stdout. One of the comments on the PR (and also 
something the bots didn't like) was to use logging for everything. I can do 
that as well.

> Run SQLLogicTests using Calcite
> -------------------------------
>
>                 Key: CALCITE-5615
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5615
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.34.0
>            Reporter: Mihai Budiu
>            Assignee: Mihai Budiu
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Sqllogictest is a program designed to verify that an SQL database engine 
> computes correct results by comparing the results to identical queries from 
> other SQL database engines.
> https://www.sqlite.org/sqllogictest/doc/trunk/about.wiki
> The nice thing about SLT is that it contains more than 7 million tests. The 
> tests only cover the core of SQL, ideally the portable part across all 
> engines. They only test integers, doubles, and strings. So they could 
> probably be part of the Calcite slow tests.
> The tests should be structured so that any query execution engine can be used.
> I plan to contribute such an implementation if people think it is useful, but 
> I haven't yet worked out all the details.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to