[
https://issues.apache.org/jira/browse/CALCITE-5615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17711625#comment-17711625
]
Mihai Budiu commented on CALCITE-5615:
--------------------------------------
Thank you Stamatis for your comments.
# Regarding the integration with tests, I would suggest to do this in a
subsequent PR. Running all 7M tests will take a long time, and I am not sure
what is the best way to invoke currently. Happy to get suggestions. I have
added a command-line flag -i which will also download and install the
sqlLogicTest source files in the specified directory if it does not exist.
# I have relicensed all files using Apache 2. Most of the code comes from a
project using the MIT license, but I understand it is OK to have dual licenses.
I hope that will work for Calcite.
# I am not sure what Nexus is, but I removed the option not to publish.
# I have attempted to address the Sonar complaints, but not all the code
smells. Hopefully they are not fatal.
I have updated my PR with these changes.
> Run SQLLogicTests using Calcite
> -------------------------------
>
> Key: CALCITE-5615
> URL: https://issues.apache.org/jira/browse/CALCITE-5615
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.34.0
> Reporter: Mihai Budiu
> Assignee: Mihai Budiu
> Priority: Minor
> Labels: pull-request-available
>
> Sqllogictest is a program designed to verify that an SQL database engine
> computes correct results by comparing the results to identical queries from
> other SQL database engines.
> https://www.sqlite.org/sqllogictest/doc/trunk/about.wiki
> The nice thing about SLT is that it contains more than 7 million tests. The
> tests only cover the core of SQL, ideally the portable part across all
> engines. They only test integers, doubles, and strings. So they could
> probably be part of the Calcite slow tests.
> The tests should be structured so that any query execution engine can be used.
> I plan to contribute such an implementation if people think it is useful, but
> I haven't yet worked out all the details.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
