[
https://issues.apache.org/jira/browse/CLOUDSTACK-10108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303525#comment-16303525
]
ASF GitHub Bot commented on CLOUDSTACK-10108:
---------------------------------------------
rhtyd commented on a change in pull request #2292: CLOUDSTACK-10108:ConfigKey
based approach for reading 'ping' configua…
URL: https://github.com/apache/cloudstack/pull/2292#discussion_r158671979
##########
File path:
engine/schema/src/com/cloud/configuration/ManagementServiceConfiguration.java
##########
@@ -0,0 +1,39 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.configuration;
+
+import org.apache.cloudstack.framework.config.ConfigKey;
+import org.apache.cloudstack.framework.config.Configurable;
+
+public class ManagementServiceConfiguration implements Configurable {
+ public static final ConfigKey<Integer> PingInterval = new
ConfigKey<Integer>("Advanced", Integer.class, "ping.interval", "60",
+ "Interval to send application level pings to make sure the
connection is still working", false);
+ public static final ConfigKey<Float> PingTimeout = new
ConfigKey<Float>("Advanced", Float.class, "ping.timeout", "2.5",
+ "Multiplier to ping.interval before announcing an agent has timed
out", true);
+
+ @Override
+ public String getConfigComponentName() {
+ return ManagementServiceConfiguration.class.getSimpleName();
+ }
+
+ @Override
+ public ConfigKey<?>[] getConfigKeys() {
+ return new ConfigKey<?>[] {PingInterval, PingTimeout};
+ }
+
Review comment:
Remove extra newline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ConfigKey based approach for reading 'ping' configuaration for Management
> Server
> --------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-10108
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10108
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: mrunalini
> Priority: Minor
>
> In CLOUDSTACK-9886, we are reading ping.interval and ping.timeout using
> configdao which involves direct reading of DB. So, replace it with ConfigKey
> based approach
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
