[
https://issues.apache.org/jira/browse/CLOUDSTACK-10108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303520#comment-16303520
]
ASF GitHub Bot commented on CLOUDSTACK-10108:
---------------------------------------------
rhtyd commented on a change in pull request #2292: CLOUDSTACK-10108:ConfigKey
based approach for reading 'ping' configua…
URL: https://github.com/apache/cloudstack/pull/2292#discussion_r158672147
##########
File path:
engine/orchestration/src/com/cloud/vm/VirtualMachinePowerStateSyncImpl.java
##########
@@ -107,7 +104,7 @@ private void processReport(long hostId, Map<Long,
VirtualMachine.PowerState> tra
s_logger.debug("Run missing VM report. current time: " +
currentTime.getTime());
// 2 times of sync-update interval for graceful period
- long milliSecondsGracefullPeriod = PingInterval.value() * 2000L;
+ long milliSecondsGracefullPeriod =
ManagementServiceConfiguration.PingInterval.value() * 2000L;
Review comment:
Since you've introduced a new `ManagementServiceConfiguration`, why not
consume the value using a method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ConfigKey based approach for reading 'ping' configuaration for Management
> Server
> --------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-10108
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10108
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: mrunalini
> Priority: Minor
>
> In CLOUDSTACK-9886, we are reading ping.interval and ping.timeout using
> configdao which involves direct reading of DB. So, replace it with ConfigKey
> based approach
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
