jajik commented on code in PR #272: URL: https://github.com/apache/commons-daemon/pull/272#discussion_r2245229061
########## .github/workflows/codeql-analysis-cpp.yml: ########## @@ -17,7 +17,6 @@ name: "CodeQL CPP" on: push: - branches: [ master ] Review Comment: Because this limits the CI execution to the master branch only. For this repository, the behavior remains the same as the master is the only branch that is used. For forks this allows execution outside of master, so for example I opened this PR from a different branch than master. With `branches: [ master ]` present I won't see a pipeline run unless I create a PR against master (and then it requires an approval). When you remove it (as this PR does), the pipeline will run in all branches in forks on push, so that people can see results *before* creating a PR. It's a big quality of life improvement, because it does not require people work in their master branches, nor modifying workflow files in their forks in order to run CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
