jajik commented on code in PR #272:
URL: https://github.com/apache/commons-daemon/pull/272#discussion_r2245265474


##########
.github/workflows/codeql-analysis-cpp.yml:
##########
@@ -17,7 +17,6 @@ name: "CodeQL CPP"
 
 on:
   push:
-    branches: [ master ]

Review Comment:
   > If you want to run CI in this repository, you need approval from one of 
its members.
   
   I know, I'm talking about actions run within the forks.
   
   Let's take this PR as an example. There was no pipeline run because I did 
not get an approval. So without removing the `branches: [ master ]` I wouldn't 
know whether my pull request / my changes did not break anything. But when we 
remove this `branches: [ master ]` limitation, a pipeline will run in my fork 
under my account at the moment I push anything into any of my branches. So I 
can then have at least partial certitude that I did not break anything.
   
   Is it clear what I mean?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to