ppkarwasz commented on code in PR #272: URL: https://github.com/apache/commons-daemon/pull/272#discussion_r2269059284
########## .github/workflows/codeql-analysis-cpp.yml: ########## @@ -17,7 +17,6 @@ name: "CodeQL CPP" on: push: - branches: [ master ] Review Comment: > For this repository, the behavior remains the same as the master is the only branch that is used. The actual impact on the behavior of this repository depends heavily on the development workflow. In my case, I don’t keep personal forks of all Apache Commons projects. Instead, I push changes directly to a feature branch in the `apache` repository and then open a PR to `main/master`. If the branch restriction is removed, **every** PR to `commons-daemon` will cause the workflow to run twice: 1. **On `push`** — triggered when I push the branch to the repository. 2. **On `pull_request`** — triggered again when the PR is opened. I understand the need to test workflow changes more flexibly, but there are alternatives that avoid this duplication: * Temporarily remove the branch restriction in your **personal fork** while working on the workflow. * Restore the restriction before opening the PR to `apache/commons-daemon`. This way, you can still test changes freely without doubling the CI runs on every PR from committers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
