jajik commented on code in PR #272: URL: https://github.com/apache/commons-daemon/pull/272#discussion_r2246238872
########## .github/workflows/codeql-analysis.yml: ########## @@ -13,13 +13,11 @@ # See the License for the specific language governing permissions and # limitations under the License. -name: "CodeQL Java" +name: "CodeQL" on: push: - branches: [ master ] pull_request: - # The branches below must be a subset of the branches above Review Comment: Yes, this is wrong. See for example [this push](https://github.com/jajik/commons-daemon/actions/runs/16649414888) and [this PR](https://github.com/jajik/commons-daemon/actions/runs/16658338691?pr=1) where [the change](https://github.com/jajik/commons-daemon/commit/b86a9b216eed7b6011e51e84704641e0fef921c2) breaks the rule in the comment (it took a while because I had a lot of actions running atm). Also, you can have workflows for pull_request only, so I don't think this makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
