ppkarwasz commented on code in PR #272:
URL: https://github.com/apache/commons-daemon/pull/272#discussion_r2269557386


##########
.github/workflows/codeql-analysis-cpp.yml:
##########
@@ -17,7 +17,6 @@ name: "CodeQL CPP"
 
 on:
   push:
-    branches: [ master ]

Review Comment:
   An example illustrates the issue best: take a look at the workflow runs for 
each commit in apache/commons-compress#685. Every time a commit was pushed to 
address a review comment, the workflows ran **twice**, once for the `push` 
event and again for the `pull_request` event, doubling the CI load 
unnecessarily.
   
   As I mentioned above, I understand the frustration of testing PRs that 
modify workflows: it’s challenging both to prepare and to review, since the 
effect is **not** visible until after the PR is merged. However, such 
workflow-changing PRs are the exception, not the norm.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to