erisu commented on code in PR #107:
URL:
https://github.com/apache/cordova-plugin-screen-orientation/pull/107#discussion_r1045090482
##########
src/ios/CDVOrientation.m:
##########
@@ -28,6 +28,74 @@ @interface CDVOrientation () {}
@implementation CDVOrientation
+-(void)handleAboveEqualIos16WithOrientationMask:(NSInteger) orientationMask
viewController: (CDVViewController*) vc result:(NSMutableArray*) result
selector:(SEL) selector
+{
+ if(@available(iOS 16.0, *)) {
Review Comment:
Can you please confirm, if this iOS 16 conditional wrapper can be removed?
I believe the method is called only on line 127 and it is already wrapped by
an iOS 16 conditional check (Line 126). If so we can remove the extra if
conditional check and de-indent the lines.
Other thing this.. I think everything looks good now and cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
