oofaish commented on code in PR #107:
URL:
https://github.com/apache/cordova-plugin-screen-orientation/pull/107#discussion_r1045104046
##########
src/ios/CDVOrientation.m:
##########
@@ -28,6 +28,74 @@ @interface CDVOrientation () {}
@implementation CDVOrientation
+-(void)handleAboveEqualIos16WithOrientationMask:(NSInteger) orientationMask
viewController: (CDVViewController*) vc result:(NSMutableArray*) result
selector:(SEL) selector
+{
+ if(@available(iOS 16.0, *)) {
Review Comment:
it doesn't look like I can replace it, because if I do then it fails to run
on iOS15 in Xcode14 (because on Xcode14 max allow is iOS16) - but I think I can
use a combination of the two directives.
the wrapper on line 33 is there to stop Xcode complaining with warnings, I
am trying to see if I can add a pragma just for that function but I dont seem
to be able to find something sensible.
anyway new PR coming up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
