erisu commented on code in PR #107:
URL:
https://github.com/apache/cordova-plugin-screen-orientation/pull/107#discussion_r1045091778
##########
src/ios/CDVOrientation.m:
##########
@@ -28,6 +28,74 @@ @interface CDVOrientation () {}
@implementation CDVOrientation
+-(void)handleAboveEqualIos16WithOrientationMask:(NSInteger) orientationMask
viewController: (CDVViewController*) vc result:(NSMutableArray*) result
selector:(SEL) selector
+{
+ if(@available(iOS 16.0, *)) {
Review Comment:
Actually can you try and replace the wrapper with this instead?
```objective-c
#if __IPHONE_OS_VERSION_MAX_ALLOWED > __IPHONE_15_5
// Code Here
#endif
```
Just to see if we can fix the CI.
I ran the CI and it failed, but this is because the earlier iOS versions are
built with a version of XCode that doesn't understand the newer identifiers.
E.g. error message:
> error: use of undeclared identifier 'UIWindowSceneGeometryPreferencesIOS'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
