erisu commented on PR #107: URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/107#issuecomment-1345502279
> should I be using > > ``` > #if __IPHONE_OS_VERSION_MAX_ALLOWED >= 160000 > ``` > > instead of > > ``` > #if __IPHONE_OS_VERSION_MAX_ALLOWED > __IPHONE_15_5 > ``` > > confirmed if I use `>= 170000` on xCode vs `>= 160000` it will switch branches in xCode14, but not with `__IPHONE_15_5` vs `__IPHONE_16_5`, not the perfect test, but there it is Awesome, the update fixes the CI and everything is now green. The changes look great, clean, and readable to me. The only other small nitpick that I had was the variable name `value16` could be renamed to `value`. Since the code was split out per iOS version, there are no more overlapping variable name usages. But, other than that, everything is great. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
