vidakovic commented on code in PR #5903:
URL: https://github.com/apache/fineract/pull/5903#discussion_r3339984505
##########
fineract-e2e-tests-runner/src/test/java/org/apache/fineract/test/initializer/suite/JobSuiteInitializerStep.java:
##########
@@ -26,7 +26,7 @@
import org.apache.fineract.client.feign.FineractFeignClient;
import org.apache.fineract.client.models.ExecuteJobRequest;
import org.apache.fineract.client.models.GetJobsResponse;
-import org.apache.fineract.client.models.PutJobsJobIDRequest;
+import org.apache.fineract.client.models.UpdateJobRequest;
Review Comment:
Let's keep the following pattern for the DTOs (aka request/response classes):
```
[Domain] + [Action] + [Suffix]
```
... in this case...
```
JobUpdateRequest
```
There are and will be a lot of "Update" commands in the code base... with
the proposed naming pattern you will immediately see the relevant classes while
typing instead listing half of the classes available in the entire system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
