vidakovic commented on code in PR #5903:
URL: https://github.com/apache/fineract/pull/5903#discussion_r3340007823
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/api/SchedulerJobApiResource.java:
##########
@@ -173,14 +178,15 @@ public Response executeJobByShortName(
}
@PUT
- @Path("{" + SchedulerJobApiConstants.JOB_ID + "}")
- @Consumes({ MediaType.APPLICATION_JSON })
+ @Path("{jobId}")
+ @Consumes(MediaType.APPLICATION_JSON)
@Operation(summary = "Update a Job", description = "Updates the details of
a job.")
- @RequestBody(required = true, content = @Content(schema =
@Schema(implementation =
SchedulerJobApiResourceSwagger.PutJobsJobIDRequest.class)))
@ApiResponse(responseCode = "200", description = "OK")
Review Comment:
This annotation is trivial. HTTP 200 is the normal case, don't have to
indicate explicitly (I know, we've done that in a lot of places... but let's
avoid code if we don't really need it). Please remove. Note: the API
compatibility plugin will indicate a backwards incompatible change... ignore
it, not an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
