vidakovic commented on code in PR #5903:
URL: https://github.com/apache/fineract/pull/5903#discussion_r3340012889
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/api/SchedulerJobApiResource.java:
##########
@@ -173,14 +178,15 @@ public Response executeJobByShortName(
}
@PUT
- @Path("{" + SchedulerJobApiConstants.JOB_ID + "}")
- @Consumes({ MediaType.APPLICATION_JSON })
+ @Path("{jobId}")
+ @Consumes(MediaType.APPLICATION_JSON)
@Operation(summary = "Update a Job", description = "Updates the details of
a job.")
- @RequestBody(required = true, content = @Content(schema =
@Schema(implementation =
SchedulerJobApiResourceSwagger.PutJobsJobIDRequest.class)))
@ApiResponse(responseCode = "200", description = "OK")
- public String updateJobDetail(@PathParam(SchedulerJobApiConstants.JOB_ID)
@Parameter(description = "jobId") final Long jobId,
- @Parameter(hidden = true) final String jsonRequestBody) {
- return updateJobDetail(IdTypeResolver.resolveDefault(),
Objects.toString(jobId, null), jsonRequestBody);
+ public UpdateJobResponse updateJobDetail(@PathParam("jobId") Long jobId,
UpdateJobRequest request) {
Review Comment:
See above comment about naming request/response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
