nidhiii128 commented on PR #5903: URL: https://github.com/apache/fineract/pull/5903#issuecomment-4629410411
Hi @vidakovic, thank you, I've addressed all your comments: Renamed DTOs and handlers to follow the [Domain][Action][Suffix] pattern (JobUpdateRequest, JobUpdateResponse, JobUpdateCommandHandler) Removed the trivial @ApiResponse(200) annotation Removed @Autowired and switched to @RequiredArgsConstructor Folded jobId into the request object in SchedulerJobHelper Moved findByJobId and retrieveSchedulerDetail out of the write service — created a new ScheduledJobReadService interface in fineract-provider (since the domain types aren't accessible from fineract-core, the interface lives in fineract-provider and SchedulerJobRunnerReadServiceImpl implements it). This took a bit of investigation to get right given the module boundaries, but I think the result cleanly separates the read concerns. Could you please take another look when you get a chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
