vidakovic commented on code in PR #5903:
URL: https://github.com/apache/fineract/pull/5903#discussion_r3388921108
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/SchedularWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -46,18 +47,6 @@ public class SchedularWritePlatformServiceJpaRepositoryImpl
implements Schedular
private final SchedulerDetailRepository schedulerDetailRepository;
- private final JobDetailDataValidator dataValidator;
-
- @Autowired
- public SchedularWritePlatformServiceJpaRepositoryImpl(final
ScheduledJobDetailRepository scheduledJobDetailsRepository,
- final ScheduledJobRunHistoryRepository
scheduledJobRunHistoryRepository, final JobDetailDataValidator dataValidator,
- final SchedulerDetailRepository schedulerDetailRepository) {
- this.scheduledJobDetailsRepository = scheduledJobDetailsRepository;
- this.scheduledJobRunHistoryRepository =
scheduledJobRunHistoryRepository;
- this.schedulerDetailRepository = schedulerDetailRepository;
- this.dataValidator = dataValidator;
- }
-
@Override
Review Comment:
Read function... read service? Please move and make sure that the write
service only exposes functions that change data. While we are here let's clean
this stuff up even if it might not be directly related to the project. Please
check the rest of the service class for similar stuff. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
