vidakovic commented on code in PR #5903:
URL: https://github.com/apache/fineract/pull/5903#discussion_r3403011615
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/config/SecurityConfig.java:
##########
@@ -400,6 +400,27 @@ public SecurityFilterChain filterChain(HttpSecurity http)
throws Exception {
.hasAnyAuthority(ALL_FUNCTIONS, ALL_FUNCTIONS_WRITE,
"UPDATE_HOOK")
.requestMatchers(API_MATCHER.matcher(HttpMethod.DELETE,
"/api/*/hooks/*"))
.hasAnyAuthority(ALL_FUNCTIONS, ALL_FUNCTIONS_WRITE,
"DELETE_HOOK")
+ // scheduler job - read
+ .requestMatchers(API_MATCHER.matcher(HttpMethod.GET,
"/api/*/jobs"))
+ .hasAnyAuthority(ALL_FUNCTIONS, ALL_FUNCTIONS_READ,
"READ_SCHEDULER")
+ .requestMatchers(API_MATCHER.matcher(HttpMethod.GET,
"/api/*/jobs/*"))
+ .hasAnyAuthority(ALL_FUNCTIONS, ALL_FUNCTIONS_READ,
"READ_SCHEDULER")
+ .requestMatchers(API_MATCHER.matcher(HttpMethod.GET,
"/api/*/jobs/short-name/*"))
+ .hasAnyAuthority(ALL_FUNCTIONS, ALL_FUNCTIONS_READ,
"READ_SCHEDULER")
+ .requestMatchers(API_MATCHER.matcher(HttpMethod.GET,
"/api/*/jobs/*/runhistory"))
+ .hasAnyAuthority(ALL_FUNCTIONS, ALL_FUNCTIONS_READ,
"READ_SCHEDULER")
+ .requestMatchers(API_MATCHER.matcher(HttpMethod.GET,
"/api/*/jobs/short-name/*/runhistory"))
+ .hasAnyAuthority(ALL_FUNCTIONS, ALL_FUNCTIONS_READ,
"READ_SCHEDULER")
+ // scheduler job - execute
+ .requestMatchers(API_MATCHER.matcher(HttpMethod.POST,
"/api/*/jobs/*"))
+ .hasAnyAuthority(ALL_FUNCTIONS, ALL_FUNCTIONS_WRITE,
"EXECUTEJOB_SCHEDULER")
Review Comment:
Should this be `EXECUTE_JOB_SCHEDULER` (missing underscore)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
