vidakovic commented on code in PR #5903:
URL: https://github.com/apache/fineract/pull/5903#discussion_r3388860871
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/api/SchedulerJobApiResource.java:
##########
@@ -87,6 +91,7 @@ public class SchedulerJobApiResource {
private final PlatformSecurityContext context;
private final FineractProperties fineractProperties;
private final SqlValidator sqlValidator;
Review Comment:
Is this something that should reside in a service? Or is this validation
like in Jakarta Validation of input parameters? SqlValidator is a very low
level implementation detail that we shouldn't reveal in the REST layer... my 2
cents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
