[
https://issues.apache.org/jira/browse/FLINK-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272447#comment-16272447
]
ASF GitHub Bot commented on FLINK-7748:
---------------------------------------
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4761#discussion_r154023982
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
@@ -671,7 +671,7 @@ else if (current == ExecutionState.CANCELING) {
jobConfiguration, taskConfiguration,
userCodeClassLoader,
memoryManager, ioManager,
broadcastVariableManager,
accumulatorRegistry, kvStateRegistry,
inputSplitProvider,
- distributedCacheEntries, writers, inputGates,
+ distributedCacheEntries, writers, inputGates,
network.getTaskEventDispatcher(),
--- End diff --
wow. Could you reformat this one with one parameter per line?
> remove event listener behaviour from ResultPartitionWriter
> ----------------------------------------------------------
>
> Key: FLINK-7748
> URL: https://issues.apache.org/jira/browse/FLINK-7748
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> {{ResultPartitionWriter}} currently implements the {{EventListener}}
> interface and is used for event registration, although event publishing is
> already handled via the {{TaskEventDispatcher}}. This should be unified by
> using {{TaskEventDispatcher}} only.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
