[ https://issues.apache.org/jira/browse/FLINK-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272630#comment-16272630 ]
ASF GitHub Bot commented on FLINK-7748: --------------------------------------- Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4761#discussion_r154067761 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/ResultPartitionWriter.java --- @@ -34,12 +31,10 @@ * The {@link ResultPartitionWriter} is the runtime API for producing results. It * supports two kinds of data to be sent: buffers and events. */ -public class ResultPartitionWriter implements EventListener<TaskEvent> { --- End diff -- a quick search reveals `NetworkEnvironment.java` calling `taskEventDispatcher.registerWriterForIncomingTaskEvents(writer.getPartitionId(), writer);` and therefore `TaskEventDispatcher` itself but there, the `EventListener` interface was actually only used in `TaskEventDispatcher#publish()` which is somewhat strange - agreed > remove event listener behaviour from ResultPartitionWriter > ---------------------------------------------------------- > > Key: FLINK-7748 > URL: https://issues.apache.org/jira/browse/FLINK-7748 > Project: Flink > Issue Type: Sub-task > Components: Network > Affects Versions: 1.4.0 > Reporter: Nico Kruber > Assignee: Nico Kruber > > {{ResultPartitionWriter}} currently implements the {{EventListener}} > interface and is used for event registration, although event publishing is > already handled via the {{TaskEventDispatcher}}. This should be unified by > using {{TaskEventDispatcher}} only. -- This message was sent by Atlassian JIRA (v6.4.14#64029)