[
https://issues.apache.org/jira/browse/FLINK-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272451#comment-16272451
]
ASF GitHub Bot commented on FLINK-7748:
---------------------------------------
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4761#discussion_r154027358
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGateTest.java
---
@@ -325,9 +325,10 @@ public void testRequestBackoffConfiguration() throws
Exception {
int initialBackoff = 137;
int maxBackoff = 1001;
+ TaskEventDispatcher taskEventDispatcher = new
TaskEventDispatcher();
NetworkEnvironment netEnv = mock(NetworkEnvironment.class);
when(netEnv.getResultPartitionManager()).thenReturn(new
ResultPartitionManager());
- when(netEnv.getTaskEventDispatcher()).thenReturn(new
TaskEventDispatcher());
+
when(netEnv.getTaskEventDispatcher()).thenReturn(taskEventDispatcher);
--- End diff --
what is the purpose of this change?
> remove event listener behaviour from ResultPartitionWriter
> ----------------------------------------------------------
>
> Key: FLINK-7748
> URL: https://issues.apache.org/jira/browse/FLINK-7748
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> {{ResultPartitionWriter}} currently implements the {{EventListener}}
> interface and is used for event registration, although event publishing is
> already handled via the {{TaskEventDispatcher}}. This should be unified by
> using {{TaskEventDispatcher}} only.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
