[
https://issues.apache.org/jira/browse/FLINK-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272446#comment-16272446
]
ASF GitHub Bot commented on FLINK-7748:
---------------------------------------
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4761#discussion_r154021028
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/iterative/task/IterationHeadTask.java
---
@@ -223,8 +225,10 @@ private void readInitialSolutionSet(JoinHashMap<X>
solutionSet, MutableObjectIte
private SuperstepBarrier initSuperstepBarrier() {
SuperstepBarrier barrier = new
SuperstepBarrier(getUserCodeClassLoader());
- this.toSync.subscribeToEvent(barrier,
AllWorkersDoneEvent.class);
- this.toSync.subscribeToEvent(barrier, TerminationEvent.class);
+ TaskEventDispatcher taskEventDispatcher =
getEnvironment().getTaskEventDispatcher();
+ ResultPartitionID partitionId = this.toSync.getPartitionId();
--- End diff --
nit: remove `this`
> remove event listener behaviour from ResultPartitionWriter
> ----------------------------------------------------------
>
> Key: FLINK-7748
> URL: https://issues.apache.org/jira/browse/FLINK-7748
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> {{ResultPartitionWriter}} currently implements the {{EventListener}}
> interface and is used for event registration, although event publishing is
> already handled via the {{TaskEventDispatcher}}. This should be unified by
> using {{TaskEventDispatcher}} only.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
