[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

[NicoK]

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4552#discussion_r159400371
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/SequenceNumberingViewReader.java
 ---
    @@ -77,6 +83,37 @@ void requestSubpartitionView(
                }
        }
     
    +   public void addCredit(int credit) {
    +           numCreditsAvailable += credit;
    +   }
    +
    +   public void notifyAvailableChanged(boolean update) {
    --- End diff --
    
    `notifyAvailabilityChanged` or actually rather `setAvailability`?
    also, please add a comment on what this is about / what "availability" 
means here
      


---