Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r160361957 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java --- @@ -88,6 +93,35 @@ public void run() { }); } + /** + * Try to enqueue the reader once receiving credit notification form the consumer or receiving + * non-empty reader notification from the producer. Only one thread would trigger the actual + * enqueue after checking the reader's availability, so there is no race condition here. + */ + void triggerEnqueueAvailableReader(final SequenceNumberingViewReader reader) throws Exception { --- End diff -- I interpret this tag actually not only for methods that are *only* used by testing, but for those where we had to increase visibility, e.g. from `private` to `package-private` as here, to be usable in tests.
---