Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4552#discussion_r160695373
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
 ---
    @@ -98,20 +135,35 @@ public void close() {
                }
        }
     
    +   /**
    +    * Adds to maintain the unannounced credits from the consumer and it 
may trigger
    +    * enqueue the corresponding reader for this consumer transferring data.
    +    *
    +    * @param receiverId The input channel id to identify consumer.
    +    * @param credit The unannounced credits of the consumer.
    +    */
    +   public void addCredit(InputChannelID receiverId, int credit) throws 
Exception {
    --- End diff --
    
    could be `package-private`


---

Reply via email to