Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4552#discussion_r160714424
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
---
@@ -250,10 +304,12 @@ private void handleException(Channel channel,
Throwable cause) throws IOExceptio
private void releaseAllResources() throws IOException {
SequenceNumberingViewReader reader;
- while ((reader = nonEmptyReader.poll()) != null) {
+ while ((reader = availableReaders.poll()) != null) {
--- End diff --
Previously, we did not have access to all views but only those with data,
but shouldn't we release all views instead? Especially now since there are
views with data but with not enough credit.
---
