Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/5954#discussion_r186375693
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
---
@@ -212,7 +212,7 @@ public void start(JobMasterId jobMasterId, String
newJobManagerAddress) throws E
// release all registered slots by releasing the corresponding
TaskExecutors
for (ResourceID taskManagerResourceId : registeredTaskManagers)
{
- releaseTaskManagerInternal(taskManagerResourceId);
+ releaseTaskManagerInternal(taskManagerResourceId, null);
--- End diff --
I would try to avoid null here. It is still helpful to have a message that
says "SlotPool is shutting down".
---
