Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/5954#discussion_r186375841
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
---
@@ -1050,11 +1050,12 @@ else if (availableSlots.tryRemove(allocationID)) {
* when we find some TaskManager becomes "dead" or "abnormal", and we
decide to not using slots from it anymore.
*
* @param resourceId The id of the TaskManager
+ * @param cause for the release the TaskManager
*/
@Override
- public CompletableFuture<Acknowledge> releaseTaskManager(final
ResourceID resourceId) {
+ public CompletableFuture<Acknowledge> releaseTaskManager(final
ResourceID resourceId, final Exception cause) {
--- End diff --
I would use `Throwable` in the signatures. It may always be that some Error
is the cause (class not found, etc.)
---
