Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5954#discussion_r186376182
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolGateway.java
 ---
    @@ -86,9 +86,10 @@
         * Releases a TaskExecutor with the given {@link ResourceID} from the 
{@link SlotPool}.
         *
         * @param resourceId identifying the TaskExecutor which shall be 
released from the SlotPool
    +    * @param cause for the release the TaskManager
         * @return Future acknowledge which is completed after the TaskExecutor 
has been released
         */
    -   CompletableFuture<Acknowledge> releaseTaskManager(final ResourceID 
resourceId);
    +   CompletableFuture<Acknowledge> releaseTaskManager(final ResourceID 
resourceId, final Exception cause);
    --- End diff --
    
    Throwable, see above.


---

Reply via email to