Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5954#discussion_r186376326
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/scheduler/SchedulerTestBase.java
 ---
    @@ -296,7 +296,7 @@ public TaskManagerLocation addTaskManager(int 
numberSlots) {
                @Override
                public void releaseTaskManager(ResourceID resourceId) {
                        try {
    -                           slotPool.releaseTaskManager(resourceId).get();
    +                           slotPool.releaseTaskManager(resourceId, 
null).get();
    --- End diff --
    
    I would avoid null exceptions.


---

Reply via email to