zentol commented on a change in pull request #6754: [FLINK-10295] Add support
of passing jar arguments as list of separate strings in REST API
URL: https://github.com/apache/flink/pull/6754#discussion_r221553160
##########
File path:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandlerParameterTest.java
##########
@@ -190,7 +195,8 @@ public void testConfigurationViaJsonRequest() throws
Exception {
() -> {
final JarRunRequestBody jsonRequest = new
JarRunRequestBody(
ParameterProgram.class.getCanonicalName(),
- "--host localhost --port 1234",
+ null,
+ Arrays.asList("--host", "localhost",
"--port", "1234"),
Review comment:
this test should be duplicated instead to cover both cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
