[GitHub] zentol commented on a change in pull request #6754: [FLINK-10295] Add support of passing jar arguments as list of separate strings in REST API

[GitBox]

zentol commented on a change in pull request #6754: [FLINK-10295] Add support 
of passing jar arguments as list of separate strings in REST API
URL: https://github.com/apache/flink/pull/6754#discussion_r221551094
 
 

 ##########
 File path: 
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarRunRequestBodyTest.java
 ##########
 @@ -33,10 +35,11 @@
        }
 
        @Override
-       protected JarRunRequestBody getTestRequestInstance() throws Exception {
+       protected JarRunRequestBody getTestRequestInstance() {
                return new JarRunRequestBody(
                        "hello",
                        "world",
+                       Arrays.asList("foo", "bar"),
 
 Review comment:
   please use 2 words that are not present in the existing argument. `foo` and 
`bar` are already use as the savepointPath.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services