zentol commented on a change in pull request #6754: [FLINK-10295] Add support
of passing jar arguments as list of separate strings in REST API
URL: https://github.com/apache/flink/pull/6754#discussion_r221553008
##########
File path:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/utils/JarHandlerUtils.java
##########
@@ -26,13 +36,42 @@
import java.util.regex.Matcher;
import java.util.regex.Pattern;
+import static
org.apache.flink.runtime.rest.handler.util.HandlerRequestUtils.fromRequestBodyOrQueryParameter;
+import static
org.apache.flink.runtime.rest.handler.util.HandlerRequestUtils.getQueryParameter;
+import static
org.apache.flink.shaded.guava18.com.google.common.base.Strings.emptyToNull;
+
/**
* Utils for jar handlers.
*
* @see org.apache.flink.runtime.webmonitor.handlers.JarRunHandler
* @see org.apache.flink.runtime.webmonitor.handlers.JarPlanHandler
*/
public class JarHandlerUtils {
+ /** Parse program arguments in jar run or plan request. */
+ public static <R extends JarRequestBody, M extends MessageParameters>
List<String> getProgramArgs(
+ HandlerRequest<R , M> request, Logger log) throws
RestHandlerException {
+ JarRequestBody requestBody = request.getRequestBody();
+ List<String> programArgs = tokenizeArguments(
+ fromRequestBodyOrQueryParameter(
+ emptyToNull(requestBody.getProgramArguments()),
+ () -> getQueryParameter(request,
ProgramArgsQueryParameter.class),
+ null,
+ log));
+ List<String> programArgsList = fromRequestBodyOrQueryParameter(
Review comment:
truly a minor thing, but might I suggest to move
`fromRequestBodyOrQueryParameter(` to the next line so the indentation of this
part is identical to the above?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
