zentol commented on a change in pull request #6754: [FLINK-10295] Add support
of passing jar arguments as list of separate strings in REST API
URL: https://github.com/apache/flink/pull/6754#discussion_r221555549
##########
File path:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandlerParameterTest.java
##########
@@ -219,15 +225,40 @@ public void testConfigurationViaJsonRequest() throws
Exception {
}
@Test
- public void testParameterPrioritization() throws Exception {
+ public void testParameterPrioritizationWithProgArgsAsString() throws
Exception {
+ testParameterPrioritization(PROG_ARGS, null);
+ }
+
+ @Test
+ public void testParameterPrioritizationWithProgArgsAsList() throws
Exception {
+ testParameterPrioritization(null, PROG_ARGS);
+ }
+
+ @Test
+ public void testFailIfProgArgsAreAsStringAndAsList() throws Exception {
+ try {
+ testParameterPrioritization(PROG_ARGS, PROG_ARGS);
+ fail("IllegalArgumentException is excepted");
+ } catch (IllegalArgumentException e) {
+ // expected
+ }
+ }
+
+ private void testParameterPrioritization(List<String> programArgs,
List<String> programArgsList) throws Exception {
+ List<String> args = programArgs == null ? programArgsList :
programArgs;
Review comment:
This code is way to confusing. It strikes me as very odd that `args` is
never null, and the naming scheme is weird (args should be "argsList",
"argsStr" should be "args" to be somewhat consistent with the method arguments).
I would pass in a single collection as arguments and a simple enum for how
arguments should be passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
