zentol commented on a change in pull request #6754: [FLINK-10295] Add support
of passing jar arguments as list of separate strings in REST API
URL: https://github.com/apache/flink/pull/6754#discussion_r221548569
##########
File path:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarPlanHandler.java
##########
@@ -80,13 +79,13 @@ public JarPlanHandler(
@Override
protected CompletableFuture<JobPlanInfo> handleRequest(
- @Nonnull final HandlerRequest<EmptyRequestBody,
JarPlanMessageParameters> request,
+ @Nonnull final HandlerRequest<JarPlanRequestBody,
JarPlanMessageParameters> request,
@Nonnull final RestfulGateway gateway) throws
RestHandlerException {
final String jarId =
request.getPathParameter(JarIdPathParameter.class);
final String entryClass =
emptyToNull(HandlerRequestUtils.getQueryParameter(request,
EntryClassQueryParameter.class));
Review comment:
Since the `JarPlanRequestBody` also contains this field (and is documented
to accept it!) we should either
a) reduce the `JarPlanRequestBody` to only contain the program arguments
b) change this handler to also use `fromRequestBodyOrQueryParameter`
c) exclude this handler from this change for now and handle it in a
follow-up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
