zhijiangW commented on a change in pull request #8646: [FLINK-12735][network]
Make shuffle environment implementation independent with IOManager
URL: https://github.com/apache/flink/pull/8646#discussion_r294343863
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/iomanager/IOManager.java
##########
@@ -242,7 +242,7 @@ public abstract BulkBlockChannelReader
createBulkBlockChannelReader(
/**
* The manager used for creating/deleting file channels based on config
temp dirs.
*/
- private static class FileChannelManager {
+ public static class FileChannelManager {
Review comment:
I also considered it before. Because the `IOManager` relies on
`FileChannelManager` to implement some public methods, so I keep
`FileChannelManager` inside `IOManager`. It also makes sense to move it outside.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
