zhijiangW commented on a change in pull request #8646: [FLINK-12735][network]
Make shuffle environment implementation independent with IOManager
URL: https://github.com/apache/flink/pull/8646#discussion_r295205178
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/NettyShuffleEnvironmentConfiguration.java
##########
@@ -74,7 +78,8 @@ public NettyShuffleEnvironmentConfiguration(
boolean isCreditBased,
boolean isNetworkDetailedMetrics,
boolean forcePartitionReleaseOnConsumption,
- @Nullable NettyConfig nettyConfig) {
+ @Nullable NettyConfig nettyConfig,
+ @Nullable String[] tempDirs) {
Review comment:
it should not be null in my expectation. Just copied the format from above
parameter and forgot it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
