zhijiangW commented on a change in pull request #8646: [FLINK-12735][network]
Make shuffle environment implementation independent with IOManager
URL: https://github.com/apache/flink/pull/8646#discussion_r294352373
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/NettyShuffleEnvironmentConfiguration.java
##########
@@ -479,6 +491,7 @@ public int hashCode() {
result = 31 * result + floatingNetworkBuffersPerGate;
result = 31 * result + (isCreditBased ? 1 : 0);
result = 31 * result + (nettyConfig != null ?
nettyConfig.hashCode() : 0);
+ result = 31 * result + tempDirs.hashCode();
Review comment:
I also think `hashCode/equals` are not needed in this class. Or we do not
add the `tempDirs` for these methods which might be removed future in separate
ticket. Or add it as you suggested. Which one do you prefer?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
