zhijiangW commented on a change in pull request #8646: [FLINK-12735][network]
Make shuffle environment implementation independent with IOManager
URL: https://github.com/apache/flink/pull/8646#discussion_r295202710
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NettyShuffleEnvironment.java
##########
@@ -386,6 +391,9 @@ public void close() {
LOG.warn("Network buffer pool did not shut down
properly.", t);
}
+ // delete all the temp directories
+ fileChannelManager.close();
Review comment:
The current `close` would not throw any exceptions actually. And I could
wrap it in catch block for avoiding changes future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
