zhijiangW commented on a change in pull request #10083:
[FLINK-14472][runtime]Implement back-pressure monitor with non-blocking outputs.
URL: https://github.com/apache/flink/pull/10083#discussion_r342958896
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/slots/TaskManagerGateway.java
##########
@@ -46,22 +46,20 @@
String getAddress();
/**
- * Request a stack trace sample from the given task.
+ * Request to sample the back pressure ratio from the given task.
*
* @param executionAttemptID identifying the task to sample
- * @param sampleId of the sample
- * @param numSamples to take from the given task
- * @param delayBetweenSamples to wait for
- * @param maxStackTraceDepth of the returned sample
- * @param timeout of the request
- * @return Future of stack trace sample response
+ * @param sampleId id of the sample
+ * @param numSamples number of samples to take
+ * @param delayBetweenSamples time to wait between samples
+ * @param timeout rpc request timeout
+ * @return Future containing the task back pressure sampling results
*/
- CompletableFuture<StackTraceSampleResponse> requestStackTraceSample(
+ CompletableFuture<TaskBackPressureSampleResponse>
sampleTaskBackPressure(
Review comment:
sampleTaskBackPressure -> requestTaskBackPressure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
