zhijiangW commented on a change in pull request #10083:
[FLINK-14472][runtime]Implement back-pressure monitor with non-blocking outputs.
URL: https://github.com/apache/flink/pull/10083#discussion_r342959404
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/RpcTaskManagerGateway.java
##########
@@ -56,20 +56,18 @@ public String getAddress() {
}
@Override
- public CompletableFuture<StackTraceSampleResponse>
requestStackTraceSample(
- ExecutionAttemptID executionAttemptID,
- int sampleId,
- int numSamples,
- Time delayBetweenSamples,
- int maxStackTraceDepth,
- Time timeout) {
-
- return taskExecutorGateway.requestStackTraceSample(
+ public CompletableFuture<TaskBackPressureSampleResponse>
sampleTaskBackPressure(
+ final ExecutionAttemptID executionAttemptID,
Review comment:
It is not very necessary to add `final` for method arguments if I remembered
correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
