azagrebin commented on a change in pull request #10161: [FLINK-13986][runtime]
Clean up legacy code for FLIP-49.
URL: https://github.com/apache/flink/pull/10161#discussion_r347425435
##########
File path:
flink-mesos/src/test/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManagerTest.java
##########
@@ -270,8 +273,13 @@ protected void closeTaskManagerConnection(ResourceID
resourceID, Exception cause
// TaskExecutor templating
ContainerSpecification containerSpecification = new
ContainerSpecification();
+
+ Configuration copiedConfig = new
Configuration(flinkConfig);
+
copiedConfig.setString(TaskManagerOptions.TOTAL_PROCESS_MEMORY,
+
flinkConfig.getInteger(MesosTaskManagerParameters.MESOS_RM_TASKS_MEMORY_MB) +
"m");
+ TaskExecutorResourceSpec spec =
TaskExecutorResourceUtils.resourceSpecFromConfig(copiedConfig);
Review comment:
`MemorySize totalProcessMemory =
MemorySize.parse(flinkConfig.getInteger(MESOS_RM_TASKS_MEMORY_MB) + "m");`
`TaskExecutorResourceUtils.resourceSpecFromConfig(flinkConfig,
totalProcessMemory)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
