azagrebin commented on a change in pull request #10161: [FLINK-13986][runtime]
Clean up legacy code for FLIP-49.
URL: https://github.com/apache/flink/pull/10161#discussion_r347409556
##########
File path: flink-dist/src/main/flink-bin/bin/config.sh
##########
@@ -790,3 +614,13 @@ runBashJavaUtilsCmd() {
echo ${output}
}
+
+getTmResourceDynamicConfigsAndJvmParams() {
+ local class_path=`constructFlinkClassPath`
+ class_path=`manglePathList ${class_path}`
+
+ local dynamic_configs=$(runBashJavaUtilsCmd
GET_TM_RESOURCE_DYNAMIC_CONFIGS ${class_path} ${FLINK_CONF_DIR})
+ local jvm_params=$(runBashJavaUtilsCmd GET_TM_RESOURCE_JVM_PARAMS
${class_path} ${FLINK_CONF_DIR})
Review comment:
Could we have 2 functions for dynamic params and JVM args?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
