azagrebin commented on a change in pull request #10161: [FLINK-13986][runtime] 
Clean up legacy code for FLIP-49.
URL: https://github.com/apache/flink/pull/10161#discussion_r347776431
 
 

 ##########
 File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/UtilsTest.java
 ##########
 @@ -187,8 +190,10 @@ public void testCreateTaskExecutorCredentials() throws 
Exception {
                        hdfsDelegationTokenKind, service));
                amCredentials.writeTokenStorageFile(new 
org.apache.hadoop.fs.Path(credentialFile.getAbsolutePath()), yarnConf);
 
-               ContaineredTaskManagerParameters tmParams = new 
ContaineredTaskManagerParameters(64,
-                       64, 16, 1, new HashMap<>(1));
+               Configuration copiedConfig = new Configuration(flinkConf);
+               copiedConfig.setString(TaskManagerOptions.TOTAL_FLINK_MEMORY, 
"512m");
+               TaskExecutorResourceSpec spec = 
TaskExecutorResourceUtils.resourceSpecFromConfig(copiedConfig);
 
 Review comment:
   `TaskExecutorResourceUtils.resourceSpecFromConfig(flinkConf, 512m)`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to