azagrebin commented on a change in pull request #10161: [FLINK-13986][runtime] 
Clean up legacy code for FLIP-49.
URL: https://github.com/apache/flink/pull/10161#discussion_r347837337
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceUtilsTest.java
 ##########
 @@ -310,21 +310,6 @@ public void testConfigManagedMemoryFractionFailure() {
                validateFailInConfigurationsWithoutExplicitManagedMem(conf);
        }
 
-       @Test
-       public void testConfigManagedMemoryLegacyFraction() {
 
 Review comment:
   a bit strange that we have this commit before main commits and not as a part 
of e.g.
   09bed0858a - [FLINK-13986][core][config] Remove legacy config option 
TaskManagerOptions#LEGACY_MANAGED_MEMORY_FRACTION

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to