azagrebin commented on a change in pull request #10161: [FLINK-13986][runtime]
Clean up legacy code for FLIP-49.
URL: https://github.com/apache/flink/pull/10161#discussion_r347796487
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunnerStartupTest.java
##########
@@ -131,7 +130,7 @@ public void testMemoryConfigWrong() throws Exception {
highAvailabilityServices);
fail("Should fail synchronously with an exception");
- } catch (IllegalConfigurationException e) {
+ } catch (Throwable t) {
Review comment:
I would avoid legacy config options for this test (earlier in this test
method).
Also, we should catch the real exception `NumberFormatException`.
`TaskExecutorResourceUtils` could be also refactored (a separate hotfix commit
in the beginning) to have a method to wrap this exception with
`IllegalConfigurationException` and a message what was misconfigured wherever
we call `MemorySize.parse` to parse a memory config option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
