wangyang0918 commented on a change in pull request #11320:
[FLINK-16437][runtime] Make SlotManager allocate resource from ResourceManager
at the worker granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r388815917
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ActiveResourceManagerFactory.java
##########
@@ -81,4 +83,14 @@ private static Configuration
createActiveResourceManagerConfiguration(Configurat
ClusterInformation clusterInformation,
@Nullable String webInterfaceUrl,
ResourceManagerMetricGroup resourceManagerMetricGroup) throws
Exception;
+
+ protected WorkerResourceSpec
createDefaultWorkerResourceSpec(Configuration configuration) {
Review comment:
I am also thinking whether we could do better about the way to pass the
`DefaultWorkerResourceSpec` to `SlotManagerImpl`.
Currently, we create in the `XXResourceManager` and pass it to the
`ResourceManagerRuntimeServicesConfiguration` -> `SlotManagerConfiguration`. If
we could update the flink configuration earlier(especially for the
`taskmanager.cpu.cores`) before passing it to the `SlotManagerConfiguration`,
then we could move `DefaultWorkerResourceSpec` calculation logics into
`SlotManagerConfiguration`. Then the `ResourceManager` is not aware of
`DefaultWorkerResourceSpec` since it does not need to know. Also we could avoid
the `Nullable` annotation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
