tillrohrmann commented on a change in pull request #11320:
[FLINK-16437][runtime] Make SlotManager allocate resource from ResourceManager
at the worker granularity.
URL: https://github.com/apache/flink/pull/11320#discussion_r401738574
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImpl.java
##########
@@ -125,20 +126,29 @@
* */
private boolean failUnfulfillableRequest = true;
+ /**
+ * The default resource spec of workers to request. It could be null
iff on standalone/local setups, in which cases
+ * the {@link SlotManagerImpl} will never request any new worker.
+ */
+ @Nullable
+ private final WorkerResourceSpec defaultWorkerResourceSpec;
Review comment:
A nice side-effect would be that everywhere where we now pass `null` we
would have a nice and descriptive name `WorkerResourceSpec.UNSPECIFIED` or
`WorkerResourceSpec.getUnknownSpec()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
